Repository navigation
Fix profile expand arrow in tree view - #178
Merged
Merged
Conversation
The arrow's click bubbled into the row's own click handler, which selected the profile and opened it in the editor instead of expanding it. Stop that propagation, and have TreeComponent report expand/collapse changes upward so ConfigTree can preserve a profile's manually-opened state instead of it being wiped out on the next reactive recompute. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Visit the preview URL for this PR (updated for commit c7ed0da): https://profile-cloud-dev--pr178-fix-tree-arrow-expan-h1wipans.web.app (expires Fri, 25 Sep 2026 10:55:46 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2a004f867edf1347070dd9beedb18755187a6d4e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
ProfileCloudTreeItem.svelte: stop the arrow's click from bubbling into the row's click handler.TreeComponent.svelte: dispatch anexpandedChangeevent with the authoritative expanded-id list whenever the tree's expand state changes.ConfigTree.svelte: track manually-expanded ids from that event and merge them into the derived expanded list, guarding against redundant reassignment to avoid a reactive feedback loop.Test plan
svelte-checkpasses with no new errors introduced🤖 Generated with Claude Code