Repository navigation
Fix VSN1L/VSN1R profile overwrite being blocked by strict type check - #176
Merged
Merged
Conversation
overwriteConfigWithEditorConfig() rejected overwrites whenever the active module's type didn't exactly match the cloud config's type, so a VSN1L profile could never be overwritten while VSN1R was active (and vice versa) even though they share a profile format. Extract the VSN1L/VSN1R grouping already used in ConfigTree's isCompatible into a shared isModuleTypeCompatible helper and use it for the overwrite guard. Fixes intechstudio/grid-editor#1424 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Visit the preview URL for this PR (updated for commit 56b0de8): https://profile-cloud-dev--pr176-fix-vsn1-overwrite-dmsh6g3h.web.app (expires Thu, 13 Aug 2026 12:31:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2a004f867edf1347070dd9beedb18755187a6d4e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
overwriteConfigWithEditorConfig() rejected overwrites whenever the active module's type didn't exactly match the cloud config's type, so a VSN1L profile could never be overwritten while VSN1R was active (and vice versa) even though they share a profile format. Extract the VSN1L/VSN1R grouping already used in ConfigTree's isCompatible into a shared isModuleTypeCompatible helper and use it for the overwrite guard.
Fixes intechstudio/grid-editor#1424