Kaplan meier; Added range_with_cens_info statistic to s_surv_time()#1481
Merged
Conversation
…lihood ratio test
…ram, and export s_ancova()
Signed-off-by: David Muñoz Tord <david.munoztord@mailbox.org>
Contributor
Author
|
@Melkiades there is unrelated lint issue to my PR, want me to check it out or let it be ? |
Contributor
it is not a blocker in general (you could merge the PR even if with those) but it is happening everytime we touch a file in {tern} so probably better to do correct it when it happens (it is only removing return calls where not needed to be explicit) |
Melkiades
reviewed
Jun 3, 2026
Melkiades
reviewed
Jun 3, 2026
Melkiades
reviewed
Jun 3, 2026
Melkiades
reviewed
Jun 3, 2026
Melkiades
reviewed
Jun 4, 2026
munoztd0
commented
Jun 5, 2026
munoztd0
commented
Jun 5, 2026
Contributor
Author
|
@Melkiades I think I addressed all previous comments |
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com> Signed-off-by: David Muñoz Tord <david.munoztord@mailbox.org>
Port s ancova j
Signed-off-by: David Muñoz Tord <david.munoztord@mailbox.org>
Melkiades
approved these changes
Jun 9, 2026
Melkiades
left a comment
Melkiades
left a comment
Contributor
There was a problem hiding this comment.
Lgtm!! Thanks @munoztd0 and @danielinteractive for your work!!
Contributor
Author
Of course , I am glad it got back into tern. Can we merge the PRs now ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Fixes johnsonandjohnson/junco#160
Motivation
These enhancements have been in production use in the
juncopackage(https://github.com/johnsonandjohnson/junco) and are being contributed
back to tern.
Changes
range_with_cens_infostatistic tos_surv_time().s_surv_time()to exported functions.These are all NULL default changes and should not cause any breaking changes