Nawishta: fix author rename - #157
Merged
Merged
Conversation
PUT /api/authors/{id}/name always went through IAuthorRenameService, which
queries MaktabaDbContext directly - nonexistent for a Nawishta-backed
library (no metadata.db), surfacing as the same unhandled "SQLite Error 14"
500 the add-file bug had before its own fix.
Renamed via Nawishta's real author-update endpoint instead
(NawishtaRawApiClient.UpdateAuthorAsync, PUT .../authors/{authorId}), same
"fetch existing AuthorView, mutate the one field, PUT the whole
representation back" pattern NawishtaBookMutationService.UpdateMetadataAsync
already uses for books. Same name-collision rule as the local-library
branch (case-insensitive, excluding the author's own row) is checked
against the live author list before renaming, returning a 409 rather than
creating a name clash server-side.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PUT /api/authors/{id}/namealways went throughIAuthorRenameService, which queriesMaktabaDbContextdirectly - nonexistent for a Nawishta-backed library (nometadata.db), surfacing as the same unhandledSQLite Error 14: unable to open database file500 the add-file bug had before its own fix earlier this session.Changed
NawishtaRawApiClient.UpdateAuthorAsync(new):PUT libraries/{libraryId}/authors/{authorId}.AuthorEndpoints.cs'sPUT /{id}/namenow branches for a Nawishta-backed library: fetches the existingAuthorView, mutates justName, and PUTs the whole representation back - same patternNawishtaBookMutationService.UpdateMetadataAsyncalready uses for books. Same name-collision rule as the local-library branch (case-insensitive, excluding the author's own row) is checked against the live author list first, returning a 409 rather than creating a name clash server-side.Test plan
dotnet build backend/Maktaba.sln- succeeds.Closes #145
🤖 Generated with Claude Code