Conversation
There was a problem hiding this comment.
Pull request overview
Updates the published @input-output-labs/ngleaf package metadata to better declare runtime requirements so consuming apps don’t end up with missing modules at runtime.
Changes:
- Bumps library version to
2.20.22. - Adds runtime
dependencies(@swimlane/ngx-charts,awesome-phonenumber,lodash.merge). - Adds Angular/Ngrx/Translate/RxJS
peerDependencies.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose to add the dependencies and peerDependencies in the package.json of the library.
Currently I've experienced in an app the npm install being successful but then in the run of the app some packages were missing, I think it comes from this required change but I'm not 100% sure. If @NablaT can check?