Skip to content

Update version comment header (1.0.5) - #7

Merged
Chrico merged 2 commits into
inpsyde:mainfrom
davidedammino:main
Sep 2, 2026
Merged

Chrico merged 2 commits into
inpsyde:mainfrom
davidedammino:main

Conversation

@davidedammino

Copy link
Copy Markdown
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (N/A — metadata-only change, no code touched)
  • Docs have been added/updated (N/A)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix (version metadata correction). Version 1.0.4 was tagged without updating the plugin comment header in disable-comments.php.

What is the current behavior? (You can also link to an open issue here)

Version 1.0.4 still gets identified by WordPress as 1.0.3, which is flagged as vulnerable (WPScan report). Security scanners report a false positive on sites that are actually running the patched code.

What is the new behavior (if this is a feature change)?

Comment header updated to reflect 1.0.4, so WordPress and security scanners correctly identify the installed version.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No code changes, but the existing 1.0.4 tag would need to be re-tagged to include this fix. If re-tagging isn't an option, I can update this PR to bump the version to 1.0.5 instead.

Security impact

What changed (security perspective):
No functional code changed — only the version string in the plugin comment header. This fixes version misreporting: the patched 1.0.4 release was self-identifying as 1.0.3, causing WPScan and similar tools to flag it as vulnerable. Correct reporting lets users and scanners verify they're on the patched release.

Testing done:
Confirmed the plugin now shows 1.0.4 in the WordPress admin Plugins page; diff verified as a single-line change.

Residual risk (link Jira if any):
Sites that already installed the mislabeled 1.0.4 will keep reporting as 1.0.3 until they update to the corrected release (re-tagged 1.0.4 or 1.0.5). No Jira ticket.

Other information

Full diff is one line:

 * Version: 1.0.4

@Chrico

Chrico commented Sep 2, 2026

Copy link
Copy Markdown
Member

Hey @davidedammino . Thanks for the PR. We have immutable tags in our org, which means we cannot overwrite the 1.0.4 release. You need to update this header to 1.0.5. Afterward, we can create a 1.0.5 release. 👍🏻

@davidedammino davidedammino changed the title Update version comment header (1.0.4) Update version comment header (1.0.5) Sep 2, 2026
@davidedammino

Copy link
Copy Markdown
Contributor Author

@Chrico Updated, thanks!

@Chrico
Chrico merged commit 49833bd into inpsyde:main Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants