Persist shared Properties collapse state and preserve scroll (#2831)#774
Merged
Conversation
* feat(ok): persist shared Properties collapse state and preserve scroll Add a field-count badge next to the Properties label and align property rows flush to the disclosure edge. Persist whether Properties is expanded or collapsed as a user-global preference shared live across open documents. Preserve each document scroll position relative to its body content so toggling Properties on one document no longer shifts another. * test(ok): make props scroll e2e condition-based and register in CI Replace page.waitForTimeout with expect.poll condition waits (satisfies the e2e-stop-rules STOP rule) and add the suite to the test:e2e PR-tier list so the e2e-list-membership guard passes. * fix(ok): address review on Properties collapse PR Correct the --prop-drag-gutter comment: the raw drag-handle gutter is 1.25rem; the tuned 1.375rem lands the type icons under the chevron glyph (px-1 inset), so the comment no longer claims a wrong w-4+gap-1 derivation. Also clear the listeners Set in __resetPropertiesCollapsedForTests so orphaned subscribers can't leak across tests. * refactor(ok): address review considerations Bound docScrollBodyOffset with an LRU cap (MAX_TRACKED_DOC_SCROLL) so a long session can't grow it without limit; entries still outlive Activity eviction by design. Extend the scroll-preserve e2e to also cover the expand direction (anchor moves down), so a sign error that only shows on expand would be caught. GitOrigin-RevId: afcac29c133d10feb0df886c8234ce1d8920fd6a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copybara-translated 1 Inkeep OSS change. Rebase-merge this PR so the prepared commit lands directly on public main.