fix(bug-report): include the crash minidump in crash-triggered reports (#2726)#700
Merged
Conversation
…s (#2726) A crash-detected report invitation (boot-time dirty-shutdown/minidump scan or a live render/child process death) is precisely a request to report a crash, yet the crash-dump opt-in defaulted OFF, so crash reports usually arrived without the minidump that triggered them (PRD-7403, split from PRD-7394). The attach mechanism was fully wired; only the default did not serve the crash-report case. Make the crash-dump opt-in appear only when main confirms a minidump is on disk for the event, and default it ON when it does: - Thread an authoritative minidumpAvailable signal from main onto OkBugReportCrashDetectedEvent (only main can stat the crash-dumps dir). Boot events derive it from the freshness scan; process-gone events check the dir at arm time (best-effort: Crashpad may still be flushing). - The report dialog renders the crash-dump row only when minidumpAvailable is true, defaults it checked, and sends includeCrashDump only then. A dump-less invite (e.g. a dirty shutdown with no native dump) shows no dead checkbox. Plain compose is unchanged and still carries no dump. Consent is preserved without a silent send: the row stays a visible, uncheckable checkbox, its note still states the memory is unredactable and can contain document content, and nothing leaves the machine until the user reviews the exact bundle (whose review card flags "crash dump not redacted"). The no-silent-send invariant (N7) is kept. NOTE FOR REVIEW: this flips the deliberately locked default-OFF from spec 2026-06-27-ok-report-bug-experience (R13f / OQ12 / D18), which lists "defaulting minidump inclusion to ON" as an ASK_FIRST guardrail. Approved by Andrew for the detected-crash + dump-available case specifically. GitOrigin-RevId: 9027463f803660cee61c5bbcfcf4b4c2cf35f9da
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copybara-translated 1 Inkeep OSS change. Rebase-merge this PR so the prepared commit lands directly on public main.