Skip to content

Render the native menu from the shared command registry (Phase 2b) (#2721) #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inkeep-oss-sync merged 1 commit into from
Jul 20, 2026
Merged

Render the native menu from the shared command registry (Phase 2b) (#2721) #699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .changeset/menu-registry-phase-2b.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
---
"@inkeep/open-knowledge": patch
---

Internal refactor (no user-facing change): the native application menu now
renders its actionable command leaves from the same shared command registry the
Cmd+K palette uses, so each command's identity — label, accelerator, keyboard
shortcut, availability, and menu placement — is declared once in
`@inkeep/open-knowledge-core` instead of being hand-maintained in two lists.
Command availability is a pure, declarative evaluator both surfaces call; the
menu's structural scaffolding (roles, separators, submenus, the dynamic
Recent-project list, and the platform branches) stays declarative. The
"Check for updates" and "Settings" platform placements are now data-driven,
and a ratchet fails the build if a command is ever hand-placed twice in the same
platform's menu bar. Menu items, order, labels, accelerators, and enabled/checked
states are unchanged on every platform.
Loading