fix(auth): initialize permissions for space bearer tokens - #94
Merged
Merged
Conversation
agreenspan
marked this pull request as ready for review
September 17, 2026 15:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Space-owned bearer tokens authenticated successfully but received no Space permission grants. The production token middleware called only
setupOrgPermissionsfor tokens without a user, so a viewer token was denied its own Space's customer list. The test harness already called both setup helpers and masked this production-path gap.Call the existing
setupSpacePermissionshelper in that branch. It grants only the Space and role declared by the token. New database-backed regressions use real bearer lookup and verify own-Space access, sibling/foreign-Space denial, role restrictions and the absence of a user identity on user-only routes.Validation:
bun run checkwas attempted and stops at 134 existing lint errors in unchanged files.Draft pending the repository-wide verification gate.