COMM-013: default render fallback is the platform tier's own template - #103
Merged
Merged
Conversation
…w — unbranded, stable, still sent; fail is the opt-in Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uyo2oHpjDz4zjRyqRWH6bP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up ruling after #102 merged: the default when a branded render has an issue (or cannot be composed) is to re-render the platform tier's own row of the same slug — unbranded but stable — so the mail still goes out.
failbecomes the opt-in for a template that would rather wait and be fixed.degradeand an explicitsubstituteslug are unchanged. A render that already resolved at the platform tier has nowhere to fall back to and fails as before. Every fallback must render clean.Tests:
apps/api/src/lib/emailTemplate.test.ts— a broken Organization-tier template sends the platform version; the platform tier's own issue still refuses;failopt-in refuses instead of unbranding.🤖 Generated with Claude Code
https://claude.ai/code/session_01Uyo2oHpjDz4zjRyqRWH6bP