Age oracles - #474
Merged
Merged
Conversation
Contributor
Greptile SummaryAdds 300 persisted oracle cases that pin the current behavior of
Confidence Score: 5/5The PR appears safe to merge, with the new Age oracle cases correctly registered for automatic test discovery. The changes are confined to tests and test-generation assets, and the aggregate Age test list is discoverable through its Expecto test attribute. Important Files Changed
Reviews (1): Last reviewed commit: "test: Add tests for Age.toString" | Re-trigger Greptile |
halcwb
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add 300 test cases covering three
Agefunctions to pin down current behaviour.Further information
Related to #469 this pull request continues work getting infrastructure in place so that we can safely change the
Agetype. It uses three F# script files to have FsCheck generate 100 test cases for each. These test cases are then persisted as parametrized tests so that we have good coverage of the three functions, later allowing us to refactorAge.Divergence from plan
This pull request is, unfortunately, much larger than 200 lines of code, since most of it is auto-generated, and we need to capture enough test cases to have confidence that refactoring is safe.
Verification
dotnet run servertestspass.Author checklist
Note
An issue and agreed implementation plan are necessary unless either fewer than 25 lines have been changed or only documentation has been changed.
I confirm that these changes:
.fssource files (except client-side UI code).AI/Vibe Coding Disclosure
I confirm that I have:
Reviewer checklist
I confirm that: