refactor: Delete unused code - #472
Merged
Merged
Conversation
Contributor
Greptile SummaryThis PR removes unused validation and conversion helpers from
Confidence Score: 5/5The PR appears safe to merge because the removed helpers have no repository callers or identified external publication path. The change only deletes unreferenced age validation and conversion helpers while leaving the actively used age getters and patient update functions intact. Important Files Changed
Reviews (1): Last reviewed commit: "refactor: Delete unused code" | Re-trigger Greptile |
halcwb
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Delete unused code in
Shared.Models.Patient.Age.Further information
As discussed in #469 the
Agetype and the associated module could be significantly simplified.Divergence from plan
Getting rid of unused code is the first step in simplifying
Age, but to keep pull-request line count down, I submit this as a separate pull request, valuable in itself.Verification
dotnet run servertestspass.Author checklist
Note
An issue and agreed implementation plan are necessary unless either fewer than 25 lines have been changed or only documentation has been changed.
I confirm that these changes:
.fssource files (except client-side UI code).AI/Vibe Coding Disclosure
I confirm that I have:
Reviewer checklist
I confirm that: