Conversation
andrey-kuprianov
left a comment
There was a problem hiding this comment.
As in #98, I have essentially the same comments.
- It is unclear at all whether this feature is needed by our users. We should first discuss with the users, and with our PO (@tesnimab), whether this is needed.
- I suppose that actually most of our users simply will want to use some binary that is already present on their machines (dev version, not yet released on the main repo)
- I can imagine lots of situations when it won't work at all:
- if the project is compiled not using
make build(e.g. some custom build process) - if there are multiple executables produced
- if the project is compiled not using
- The implementation is rushed, and I suppose there are cases where it will work not as expected
- e.g. , I am not particularly fond of including things like
glob("*/*")into our codebase. It may have many unforeseen consequences
- e.g. , I am not particularly fond of including things like
Besides, we are in the feature freeze now, before the prototype release, so no new features should be added. Please postpone working on that till the prototype release.
|
I need this feature to write tests for methods used in chain subcommand. If this PR is rejected, I will still need it. I will put it somewhere like
It is targeted for CI capabilities.
It is not the exclusive way to set up chain binary.
I agree with this. But this works for most cosmos-sdk chain binary.
Did you mean a long runtime to loop |
Closes #111
Example usage,