feat: Accept string literals in the fields of a record type#4664
Merged
Conversation
Marwes
force-pushed
the
property_key_in_record_type
branch
2 times, most recently
from
April 12, 2022 12:53
9796261 to
e396f8b
Compare
Marwes
marked this pull request as ready for review
April 12, 2022 13:37
nathanielc
approved these changes
Apr 21, 2022
nathanielc
left a comment
nathanielc
left a comment
Contributor
There was a problem hiding this comment.
LGTM Can you update the docs/SPEC.md with the new grammar? I don't need to re-review once that is done.
added 2 commits
April 22, 2022 13:36
For #4388 we need a way to describe a type (label) variable in place of a record field. As type variables are described as a single, uppercase letter, mimicking that syntax will make it impossible to describe the literal field name "A", "B", etc. By allowing a string literal in this location one can always use this syntax to describe these single letter field names and also describe any other fields which do not fit into an `identifier`, for example `"field with spaces"`, `"symbols#%^"`.
Marwes
force-pushed
the
property_key_in_record_type
branch
from
April 22, 2022 11:36
e396f8b to
883d435
Compare
Marwes
force-pushed
the
property_key_in_record_type
branch
from
April 22, 2022 12:50
883d435 to
f42f690
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #4388 we need a way to describe a type (label) variable in place of a record field.
As type variables are described as a single, uppercase letter, mimicking that syntax will make it
impossible to describe the literal field name "A", "B", etc. By allowing a string literal in this location one can always use this syntax to describe these single letter field names and also describe any other fields which do not fit into an
identifier, for example"field with spaces","symbols#%^".Based on #4663