Repository navigation
Fix selector reformulation with MutableArithmetics v1.9 - #150
Merged
pulsipher merged 1 commit intoOct 30, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #150 +/- ##
=======================================
Coverage 99.73% 99.73%
=======================================
Files 22 22
Lines 2608 2610 +2
=======================================
+ Hits 2601 2603 +2
Misses 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dnguyen227
marked this pull request as ready for review
October 29, 2026 18:30
Member
Author
|
@pulsipher ready for review. |
pulsipher
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI started failing in the Basic Steps tests (
test_basic_step_complement) after MutableArithmetics went from v1.8 to v1.9. The issue is related to sum().Relevant info is here. jump-dev/MutableArithmetics.jl#380
It looks like MA.jl now works out the result type of a sum from the element type of the vector. The selector is
Vector{AbstractJuMPScalar}and the resulting type that comes out isAnywhich isnt allowed.Without defining the
GenericAffExprwe get the error:MethodError: no method matching zero(::Type{Any})