Repository navigation
⚡ Bolt: Cache script source reads, compilation, and AST imports - #21
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What:
Added
@functools.lru_cache(maxsize=256)helper functions (_read_file_cachedand_check_script_compile) keyed on(path, mtime)inscripts/critique_10khr_runner.py. Used context managers (with io.open(...) as f:) when reading script sources.🎯 Why:
During skill rubric scoring (
score_skillandrun_full_assessment), multiple dimension checkers (check_correctness,check_scripts_help, andcheck_module_scope_imports) repeatedly opened script files, compiled Python bytecodes in-memory, and parsed ASTs. This created thousands of redundant file reads, file handle leaks (ResourceWarning: unclosed file), and CPU-bound compile/parse operations.📊 Impact:
ResourceWarningwarnings during unit test runs.🔬 Measurement:
Run
PYTHONPATH=scripts python3 -m unittest discover -s teststo verify all unit tests pass cleanly withoutResourceWarningwarnings.PR created automatically by Jules for task 16283364807247077254 started by @indigokarasu