Consider reciprocal flag on network when building rota#621
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Crosslink’s broker-side Directory adapter to take a network-level reciprocal flag into account when deciding whether a supplier tier (free vs paid) is eligible, and extends the Directory OpenAPI schema accordingly.
Changes:
- Add
reciprocal(optional boolean) to the DirectoryNetworkschema and the broker’s internalNetworkmodel. - Extend
ApiDirectory.FilterAndSortto require that a tier’s cost is compatible with at least one shared network between requester and supplier. - Add tests covering paid vs reciprocal network filtering behavior in rota building.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| directory/directory_api.yaml | Adds reciprocal: boolean to the Network schema so clients can consume the flag. |
| broker/adapter/directory.go | Extends internal Network model with Reciprocal *bool to carry the API field through. |
| broker/adapter/api_directory.go | Applies network reciprocity constraints when matching tiers during FilterAndSort. |
| broker/test/adapter/api_directory_test.go | Adds unit tests verifying paid/reciprocal network constraints affect supplier selection as intended. |
adamdickmeiss
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.