Repository navigation
feat: Screen::scheme; release 0.10.0 - #57
Merged
Merged
Conversation
A screen states whether its glass shows light marks on a dark ground
("dark": it emits — TFT, AMOLED, LED, VFD) or dark marks on a light one
("light": it reflects — e-paper, a reflective STN). A physical fact, not a
colour: a framework picks its colours for it, as CSS does for color-scheme.
screens.list()/get() report it; anything but "light" is "dark".
0.10.0 is dated and versioned (library.json, idf_component.yml).
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen::scheme:"dark"(light marks on a dark ground: glass that emits, such as TFT, AMOLED, LED or VFD) or"light"(dark marks on a light ground: glass that reflects, such as e-paper or a reflective STN). It's a physical fact, not a colour: a framework picks its colours for the scheme, as CSS does forcolor-scheme.screens.list()andscreens.get()report it. Anything but"light"is"dark". This replaces a per-board colour palette module in hawthorn-firmware.library.jsonandidf_component.ymlgo to 0.10.0, and the changelog entry is no longer "unreleased". Once this merges, taggingv0.10.0publishes.Tests: unit 269/269 (new:
test_scheme_is_dark_unless_the_screen_says_light); the plugin'srun.sh9/9; static analysis clean. The plugin's copy ofprompts/sandbox.mdis refreshed.🤖 Generated with Claude Code