Repository navigation
feat: pass Courier's NetworkReady state and hook through the Sandbox - #54
Merged
Merged
Conversation
Sandbox::onNetworkReady(cb) forwards Courier 0.9.0's onNetworkReady hook, Sandbox::enterNetworkReady() forwards Client::enterNetworkReady() (false without a network), and NetworkReady drives the status text and LED. Courier floor moves to ^0.9.0; version 0.9.0. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…k pauses Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Changes since approval, from a release review (60ed43c). Nothing in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passes Courier 0.9.0's
NetworkReadystate through the Sandbox.onNetworkReady(cb)is a single-slot passthrough of Courier's blocking network-ready hook. It fires on every entry toNetworkReady: WiFi is up, time sync has been attempted, and no persistent transport is running.enterNetworkReady()forwards to Courier. It returnsfalsewithout a network.NetworkReady, the status text reads "Network ready" and the LED is cyan, the same colour asWifiConnectedandTransportsConnecting.^0.9.0, and this is version 0.9.0.This depends on inanimate-tech/courier#33 and its 0.9.0 release. Builds against the registry won't resolve until that release is published. The native tests use the stub
Courier.h, which gains the new enum value and hooks.test_sandbox_network_readyis a new suite with 5 tests, and all 230 native tests and cppcheck pass.🤖 Generated with Claude Code