fix: parse Product Hunt data from RSS feed#136
Open
iilw wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Product Hunt route to fetch data from the RSS feed instead of scraping the HTML, utilizing a new parseRSS utility. The reviewer suggested improving the robustness of the mapFeedItemToStory function by validating the date parsing to avoid NaN values and recommended removing the export keyword to encapsulate the helper function within the module.
Comment on lines
+50
to
+61
| export const mapFeedItemToStory = (item: ProductHuntFeedItem): ListItem | null => { | ||
| if (!item.title || !item.link) return null; | ||
|
|
||
| return { | ||
| id: item.guid ?? item.link, | ||
| title: item.title, | ||
| hot: undefined, | ||
| timestamp: item.pubDate ? Date.parse(item.pubDate) : undefined, | ||
| url: item.link, | ||
| mobileUrl: item.link, | ||
| }; | ||
| }; |
There was a problem hiding this comment.
I have a couple of suggestions for the mapFeedItemToStory function:
- Robustness:
Date.parse()can returnNaNfor invalid date strings. This can cause issues downstream, for example when creating aDateobject from the timestamp. It's better to check forNaNand returnundefinedfor the timestamp to avoid unexpected behavior. - Encapsulation: Since this function is only used within this file, the
exportkeyword can be removed to make it a private helper function for this module.
Here's a suggested implementation incorporating these points:
Suggested change
| export const mapFeedItemToStory = (item: ProductHuntFeedItem): ListItem | null => { | |
| if (!item.title || !item.link) return null; | |
| return { | |
| id: item.guid ?? item.link, | |
| title: item.title, | |
| hot: undefined, | |
| timestamp: item.pubDate ? Date.parse(item.pubDate) : undefined, | |
| url: item.link, | |
| mobileUrl: item.link, | |
| }; | |
| }; | |
| const mapFeedItemToStory = (item: ProductHuntFeedItem): ListItem | null => { | |
| if (!item.title || !item.link) return null; | |
| const timestamp = item.pubDate ? Date.parse(item.pubDate) : undefined; | |
| return { | |
| id: item.guid ?? item.link, | |
| title: item.title, | |
| hot: undefined, | |
| timestamp: timestamp && !isNaN(timestamp) ? timestamp : undefined, | |
| url: item.link, | |
| mobileUrl: item.link, | |
| }; | |
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改成用 /feed