Conversation
Collaborator
Author
|
@imranakram, Please review my thoughts and let me know if this is implemented well or if it should be done more efficiently! |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Project apply/open currently has watcher lifecycle/config issues (not disposing existing watchers and leaving package config active) and AddPluginAssembly ignores its path parameter, which can lead to incorrect behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a new “Project” concept to AutoDeployer to persist and reopen the current set of watched artifacts across sessions (assemblies and plugin packages; web resources explicitly not supported yet), integrating it into the main toolbar UI.
Changes:
- Introduces
Project/WatchFileXML-serializable model and adds Open/Save project actions (*.adproj). - Updates the main UI (ToolStrip) with a new Project dropdown and supporting icons/resources.
- Extends plugin package watcher display data (
PluginPackageName) and includes some small safety/readability tweaks.
File summaries
| File | Description |
|---|---|
| XrmToolBox.AutoDeployer/XrmToolBox.AutoDeployer.csproj | Includes new Project.cs and additional icon resources in the project. |
| XrmToolBox.AutoDeployer/WatchPluginPackageFile.cs | Exposes plugin package name for persistence/display; minor guard/bracing changes. |
| XrmToolBox.AutoDeployer/Properties/Resources.resx | Adds new bitmap resources (folder/disk/package icons) for the UI. |
| XrmToolBox.AutoDeployer/Properties/Resources.Designer.cs | Adds strongly-typed accessors for the new resources. |
| XrmToolBox.AutoDeployer/Project.cs | Adds the new Project/WatchFile model and enum for serialization. |
| XrmToolBox.AutoDeployer/MainControl.Designer.cs | Adds Project UI controls (Open/Save) and updates ToolStrip layout/tooltips. |
| XrmToolBox.AutoDeployer/MainControl.cs | Implements project open/save, project application to watchers, and package config updates. |
Review details
Files not reviewed (2)
- XrmToolBox.AutoDeployer/MainControl.Designer.cs: Generated file
- XrmToolBox.AutoDeployer/Properties/Resources.Designer.cs: Generated file
- Files reviewed: 5/10 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+99
to
+103
| private void AddPluginAssembly(string path) | ||
| { | ||
| if (ofdPlugin.ShowDialog() == DialogResult.OK) | ||
| var plugin = new WatchPluginFile(ofdPlugin.FileName, Service, this); | ||
| plugin.Changed += Plugin_Changed; | ||
| listWatching.Items.Add(plugin.ListItem); |
Comment on lines
+148
to
+151
| listWatching.Items.Clear(); | ||
| //ClearWebResourceWatchers(); | ||
| ClearPluginPackageWatchers(); | ||
| } |
| this.bSave.Name = "bSave"; | ||
| this.bSave.Size = new System.Drawing.Size(68, 28); | ||
| this.bSave.Text = "Save..."; | ||
| this.bSave.ToolTipText = "Save list of watched files to can get opened for next time."; |
Comment on lines
+6
to
+10
| public enum Type | ||
| { | ||
| PluginAssembly, | ||
| PluginPackage, | ||
| WebResource |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used to store all current watching files, to easily be able to open the same list of plugins/packages, but not webresources yet, please fulfill it for us :)
Solves #18