#169 Resize Unsecure/Secure Configuration fields with the Update Existing Step window - #170
Open
skfd wants to merge 2 commits into
Open
#169 Resize Unsecure/Secure Configuration fields with the Update Existing Step window#170skfd wants to merge 2 commits into
skfd wants to merge 2 commits into
Conversation
…esized The Description, Unsecure Configuration and Secure Configuration group boxes each used a different anchor set: Description anchored Top, Secure Configuration anchored Bottom, and Unsecure Configuration anchored neither, so it drifted to the vertical centre. Growing the Update Existing Step window therefore spread the three boxes apart and left large empty bands between them instead of enlarging the multiline fields. Host the three group boxes in a single-column TableLayoutPanel anchored to all four edges, with percentage rows (22/34/44) that reproduce the original proportions at the designer size and share any extra height between the three fields.
…nfig fields The Description field is normally a single line, so growing it with the window wasted the space the Unsecure/Secure Configuration editors need. Pin its row to its designer height (89px) and split all remaining height between the two configuration fields.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- Xrm.Sdk.PluginRegistration/Forms/StepRegistrationForm.Designer.cs: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #169
Problem
The three group boxes in the right-hand column of Update Existing Step each used a different anchor set, so none of them could grow vertically:
Top, Left, RightLeft, Right(noTop/Bottom)Bottom, Left, RightBecause
Unsecure Configurationwas anchored neither to the top nor the bottom, WinForms kept it centred, and all the extra height turned into empty bands between the three fields instead of making the editors bigger.Fix
The three group boxes now live in a single-column
TableLayoutPanel(tlpRightColumn) anchored to all four edges:Absolute, 89F. It is normally a single line, so it keeps its original height instead of consuming space the configuration editors need.Percent, 43FPercent, 57FThe 43/57 split preserves the original 129:170 proportion between the two editors, so at the designer size the form is pixel-equivalent to before. Each
RichTextBoxwas already anchored to all four sides, so the text areas themselves grow with their group box.Before / after
Both captured at a client size of 907x1100.
master)At the default 907x445 the layout is unchanged:
master)Testing
StepRegistrationForm.Designer.csofmasterand of this branch, resized at runtime so the anchor logic is exercised the way it is when the frame is dragged.Notes
StepRegistrationForm.Designer.csis touched.Descriptionfield is the oneRichTextBoxhere withoutWordWrap = false, so a long description wraps to a second line inside its fixed-height box. That behaviour is pre-existing and unchanged by this PR.