Skip to content

feat: implement Interactive Authorization flow#127

Merged
nanderstabel merged 15 commits into
devfrom
feat/interactive-authorization-flow
Jun 10, 2026
Merged

feat: implement Interactive Authorization flow#127
nanderstabel merged 15 commits into
devfrom
feat/interactive-authorization-flow

Conversation

@nanderstabel

@nanderstabel nanderstabel commented May 7, 2026

Copy link
Copy Markdown
Collaborator

Description of change

Links to any relevant issues

n/a

How the change has been tested

Added several unit tests

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nanderstabel nanderstabel added the Added A new feature that requires a minor release. label May 7, 2026
@codecov-commenter

codecov-commenter commented May 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.37037% with 72 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
oid4vci/src/wallet/mod.rs 1.58% 62 Missing ⚠️
oid4vci/src/errors.rs 0.00% 8 Missing ⚠️
oid4vci/src/interactive_authorization_request.rs 97.56% 1 Missing ⚠️
oid4vci/src/interactive_authorization_response.rs 98.75% 1 Missing ⚠️
Files with missing lines Coverage Δ
oid4vc-core/src/jwt.rs 96.05% <100.00%> (ø)
oid4vc-core/src/utils/did.rs 100.00% <100.00%> (ø)
oid4vp/src/token/vp_token_validator.rs 97.22% <100.00%> (-0.03%) ⬇️
oid4vci/src/interactive_authorization_request.rs 97.56% <97.56%> (ø)
oid4vci/src/interactive_authorization_response.rs 98.75% <98.75%> (ø)
oid4vci/src/errors.rs 38.46% <0.00%> (+10.00%) ⬆️
oid4vci/src/wallet/mod.rs 83.02% <1.58%> (-12.23%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nanderstabel nanderstabel changed the title feat: implement interactive authorization flow feat: implement Interactive Authorization flow May 28, 2026
@nanderstabel nanderstabel marked this pull request as ready for review May 28, 2026 07:26
Comment thread oid4vc-core/src/utils/did.rs
Comment thread oid4vc-core/src/utils/did.rs Outdated
Comment thread oid4vc-core/src/utils/did.rs Outdated
Comment thread oid4vc-core/src/jwt.rs
Comment thread oid4vci/src/errors.rs Outdated
@nanderstabel nanderstabel changed the base branch from dev to feat/jwt-utils June 8, 2026 12:22
Base automatically changed from feat/jwt-utils to dev June 8, 2026 12:34
@nanderstabel nanderstabel force-pushed the feat/interactive-authorization-flow branch from ecadf9a to 95069d8 Compare June 10, 2026 11:46

@Oran-Dan Oran-Dan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO comment for the errors should also reference the descriptions that we should add I think but good enough for now. We'll pick that up when we fix the other TODO comment

@nanderstabel nanderstabel merged commit 0a5090e into dev Jun 10, 2026
3 checks passed
@nanderstabel nanderstabel deleted the feat/interactive-authorization-flow branch June 10, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Added A new feature that requires a minor release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants