Repository navigation
build: bump Actions, remove redundant borrows, declare tokio features - #4
Merged
Merged
Conversation
`tokio::spawn` needs `rt` and `#[tokio::test]` needs `macros`; both were previously only enabled transitively through `mongodb` and `cqrs-es`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fixes `clippy::useless_borrows_in_formatting`, new in Rust 1.99. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tokio features
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from a dependency audit (
cargo audit,cargo outdated,cargo deny).Changes
tokiofeatures.tokio::spawnneedsrtand#[tokio::test]needsmacros. Until now both were enabled only transitively throughmongodbandcqrs-es. The library now declaresrt, and the dev-dependencies declaremacros+rt.actions/checkoutv4 → v7 (in all workflows)codecov/codecov-actionv3 → v7supercharge/mongodb-github-action1.12.0 → 1.12.1cargo-auditwithtaiki-e/install-actioninstead of compiling it withcargo installon every run.debug!calls (clippy::useless_borrows_in_formatting, new in Rust 1.99). This lint also fails onmainwith the current stable toolchain.Audit results
cargo auditon a stale local lockfile reported 8 advisories (rustls,rustls-webpki,webpki-roots,crossbeam-epoch,h2). Every patched version is semver-compatible, andCargo.lockis gitignored, so CI and downstream users already resolve to the fixed versions. No manifest change was needed.Notes
codecov-actioninputs in use (token,files,fail_ci_if_error) are unchanged in v7. Since v4, uploads require a token, which we already pass. Uploads from fork PRs may need tokenless uploads enabled in the Codecov organisation settings.cargo fmt --check,cargo clippy --all-targets --all-features -D warnings, andcargo test(16 tests) against a local MongoDB replica set all pass.🤖 Generated with Claude Code