Skip to content

Discord Invite Announcement - #26

Merged
ActuallyTaylor merged 3 commits into
mainfrom
feature/discord-invite
Sep 3, 2026
Merged

ActuallyTaylor merged 3 commits into
mainfrom
feature/discord-invite

Conversation

@ActuallyTaylor

Copy link
Copy Markdown
Collaborator

Adds support for a discord invite to start growing the community

In the future this could be a rolling set of announcments from some server. Right now just announcing discord statically is good.

Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
@ActuallyTaylor

Copy link
Copy Markdown
Collaborator Author

@claude

@claude

claude Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Claude finished @ActuallyTaylor's task in 1m 16s —— View job


Claude's Review

  • Gather context on the PR
  • Understand the request in the trigger comment
  • Review the code changes
  • Post findings

The trigger comment was just @claude with no specific ask, so here's a code review of the diff (origin/main...HEAD).

Findings

  1. Missing CHANGELOG entry — CONTRIBUTING.md/AGENTS.md require every user-facing change to get an entry under ## [Unreleased] in CHANGELOG.md. This PR adds a new first-run Discord announcement sheet but doesn't touch the changelog. Fix this →

  2. Stringly-typed symbol usage — Minna/Views/Common/AnnouncementView.swift:45 uses Image(systemName: announcement.urlSymbol), but this repo's convention (per AGENTS.md) is to use SFSafeSymbols (systemSymbol:) instead of stringly-typed Image(systemName:). Since Announcement.urlSymbol is declared as a plain String (AnnouncementView.swift:19) and populated from SFSymbol.arrowUpRight.rawValue at the call site (NavigationCore.swift), it'd be cleaner to type it as SFSymbol directly and render with Image(systemSymbol:). Fix this →

  3. Minor nit — in NavigationCore.swift, the @AppStorage key is "hasShownDiscord" but the property is named hasShownDiscordSheet. Not a bug, just a slightly confusing mismatch between the persisted key and the variable name.

  4. Cosmetic — the new asset files are named Discord Announcment.png / @2x / @3x (missing the "e" in "Announcement"). Purely internal filenames, no functional impact, but worth a rename for tidiness.

  5. Cosmetic — AnnouncementView.swift:70-83 leaves commented-out preview code (// Text("Hello") ... // .sheet(...)) around the #Preview. Consider cleaning it up since it doesn't add clarity.

Not flagged as blocking

The overall approach (one-time AppStorage-gated sheet shown via .onAppear, reusable AnnouncementView/Announcement model) is clean and reasonably extensible for future announcements. Accessibility handling (icon hidden, dismiss button labeled) looks correct.

Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
@ActuallyTaylor
ActuallyTaylor merged commit aa15d5a into main Sep 3, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant