Skip to content

Switch to telemetry deck - #25

Merged
ActuallyTaylor merged 8 commits into
mainfrom
feature/telemetrydeck
Aug 27, 2026
Merged

ActuallyTaylor merged 8 commits into
mainfrom
feature/telemetrydeck

Added onboarding funnel

7375b84
Select commit
Loading
Failed to load commit list.
Xcode Cloud / Minna | Default | Build - macOS succeeded Aug 27, 2026 in 6m 55s

68 warnings

Report Summary
Errors 0
Test Failures 0
Analysis Issues 0
Warnings 68

Details

68 Warnings

Details

  Minna/Views/Dashboard/Folders/FolderView.swift:206
      Accessibility Trait for Button Violation: All views with tap gestures added should include the .isButton or the .isLink accessibility traits (accessibility_trait_for_button)
  Minna/ModelManager.swift:95
      Implicit Optional Initialization Violation: Optional should be implicitly initialized without nil (implicit_optional_initialization)
  Packages/MinnaChat/Sources/ModelManager/Local Models/HuggingFace/HuggingFaceDownloader.swift:57
      Variable 'self' was written to, but never read
  Minna/Views/Search/AskMinnaView.swift:232
      Comma Spacing Violation: There should be no space before and one after any comma (comma)
  Minna/Views/Onboarding/DownloadingModelView.swift:37
      Todo Violation: TODOs should be resolved (Generate error codes) (todo)
  Minna/Views/Common/NotificationsView.swift:33
      Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
  Minna/Database/Import/FileImporter.swift:55
      Todo Violation: TODOs should be resolved (Tell the user and have them us...) (todo)
  Minna/Utility/Alerts/AlertCenter.swift:28
      Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
  Minna/Views/Dashboard/Folders/FolderView.swift:377
      Todo Violation: TODOs should be resolved (Figure out why the view is nev...) (todo)
  file:///Volumes/workspace/DerivedData/SourcePackages/checkouts/mlx-swift/Source/Cmlx/mlx-generated/metal/steel/attn/kernels/steel_attention.h:436
      Constexpr if is a C++17 extension
  Minna/Views/Preview/PreviewWindowParameterStore.swift:38
      Unneeded Synthesized Initializer Violation: This memberwise initializer would be synthesized automatically - you do not need to define it (unneeded_synthesized_initializer)
  Minna/Local Search/IrisDBController.swift:33
      Todo Violation: TODOs should be resolved (This should be adjustable.) (todo)
  Minna/Database/Import/FileImporter.swift:84
      Function Body Length Violation: Function body should span 50 lines or less excluding comments and whitespace: currently spans 53 lines (function_body_length)
  Packages/MinnaChat/Sources/MinnaChat/Extensions/Entry+Rendering.swift:34
      Immutable value 'toolCalls' was never used; consider replacing with '_' or removing it
  Minna/Views/Preview/FileChat.swift:184
      Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
  Minna/Views/Common/Components/NavigationTitle.swift:8
      Vertical Whitespace Violation: Limit vertical whitespace to a single empty line; currently 2 (vertical_whitespace)
  Minna/Utility/Alerts/AlertCenter.swift:37
      Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
  Minna/Views/Dashboard/Folders/FolderView.swift:39
      Todo Violation: TODOs should be resolved (Investigate Focus States) (todo)
  Minna/Views/Onboarding/ModelSetupView.swift:20
      Accessibility Label for Image Violation: Images that provide context should have an accessibility label or should be explicitly hidden from accessibility (accessibility_label_for_image)
  'ModelManager' is missing a dependency on 'Logging' because dependency scan of Swift module 'ModelManager' discovered a dependency on 'Logging'
  Packages/IrisSearch/Sources/Digester/Chunking/MarkdownChunker.swift:146
      Immutable value 'src' was never used; consider replacing with '_' or removing it
  missing creator for mutated node: ('/Volumes/workspace/DerivedData/Build/Products/Debug/mlx-swift_Cmlx.bundle/Contents/MacOS')
  Minna/Views/Onboarding/ProviderSetupView.swift:45
      Unused Closure Parameter Violation: Unused parameter in a closure should be replaced with _ (unused_closure_parameter)
  Minna/Views/Settings/Screens/InstallModelsView.swift:22
      Result of call to 'listModels()' is unused
  Minna/Views/Common/File Cards/GridFileCard.swift:23
      Accessibility Label for Image Violation: Images that provide context should have an accessibility label or should be explicitly hidden from accessibility (accessibility_label_for_image)
  Minna/ModelManager.swift:96
      Implicit Optional Initialization Violation: Optional should be implicitly initialized without nil (implicit_optional_initialization)
  file:///Volumes/workspace/DerivedData/SourcePackages/checkouts/mlx-swift/Source/Cmlx/mlx-generated/metal/steel/attn/kernels/steel_attention.h:356
      Constexpr if is a C++17 extension
  file:///Volumes/workspace/DerivedData/SourcePackages/checkouts/mlx-swift/Source/Cmlx/mlx-generated/metal/steel/utils/integral_constant.h:108
      Constexpr if is a C++17 extension
  Packages/IrisSearch/Sources/IrisSearch/FaissIndex.swift:127
      Initialization of immutable value 'indexURL' was never used; consider replacing with assignment to '_' or removing it
  Minna/Views/Common/NotificationsView.swift:10
      Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
  Minna/Views/Chat/ModelName.swift:13
      Use of protocol 'Model' as a type must be written 'any Model'; this will be an error in a future Swift language mode
  Minna/Views/Search/Common/IndexingSearchBar.swift:50
      Accessibility Label for Image Violation: Images that provide context should have an accessibility label or should be explicitly hidden from accessibility (accessibility_label_for_image)
  Minna/Database/Import/FileImporter.swift:73
      Todo Violation: TODOs should be resolved (Move this off of the main thre...) (todo)
  Minna/Views/Common/MinnaLogo.swift:18
      Accessibility Label for Image Violation: Images that provide context should have an accessibility label or should be explicitly hidden from accessibility (accessibility_label_for_image)
  Minna/Views/Navigation/NavigationCore.swift:161
      Todo Violation: TODOs should be resolved (Add better setup instructions.) (todo)
  Minna/Utility/Alerts/AlertCenter.swift:26
      Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
  Minna/Views/Chat/Entry Views/ToolCallsView.swift:51
      Vertical Whitespace Violation: Limit vertical whitespace to a single empty line; currently 2 (vertical_whitespace)
  Minna/Views/Preview/PreviewWindowParameterStore.swift:46
      Unneeded Synthesized Initializer Violation: This memberwise initializer would be synthesized automatically - you do not need to define it (unneeded_synthesized_initializer)
  Minna/Utility/Alerts/AlertCenter.swift:11
      Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
  Minna/Database/FrontendDatabase.swift:40
      Todo Violation: TODOs should be resolved (Try and find an existing unfil...) (todo)
  Minna/Utility/Alerts/AlertCenter.swift:12
      Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
  Minna/Views/Preview/FileChat.swift:192
      Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
  Minna/Utility/Alerts/AlertCenter.swift:10
      Vertical Whitespace Violation: Limit vertical whitespace to a single empty line; currently 2 (vertical_whitespace)
  Minna/Views/Common/File Cards/ListFileCard.swift:40
      Accessibility Label for Image Violation: Images that provide context should have an accessibility label or should be explicitly hidden from accessibility (accessibility_label_for_image)
  Minna/Views/Common/NotificationsView.swift:108
      Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
  Minna/Views/Navigation/NavigationCore.swift:114
      Todo Violation: TODOs should be resolved (Restart a download of the mode...) (todo)
  Minna/Views/Common/File Cards/OpaqueFileCard.swift:108
      Function Body Length Violation: Function body should span 50 lines or less excluding comments and whitespace: currently spans 78 lines (function_body_length)
  Minna/Views/Common/NotificationsView.swift:106
      Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
  Minna/Views/Search/AskMinnaView.swift:33
      Todo Violation: TODOs should be resolved (Figure out when to load and un...) (todo)
  Minna/Views/Chat/Entry Views/GeneratedContentView.swift:31
      Todo Violation: TODOs should be resolved (Pretty Print JSON) (todo)
  Packages/IrisSearch/Sources/Digester/Chunking/MarkdownChunker.swift:146
      Immutable value 'range' was never used; consider replacing with '_' or removing it
  Minna/Views/Dashboard/Folders/FolderView.swift:221
      Accessibility Trait for Button Violation: All views with tap gestures added should include the .isButton or the .isLink accessibility traits (accessibility_trait_for_button)
  Minna/Utility/Alerts/AlertCenter.swift:30
      Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
  'DatabaseSchema' is missing a dependency on 'Logging' because dependency scan of Swift module 'DatabaseSchema' discovered a dependency on 'Logging'
  Minna/Views/Common/NotificationsView.swift:35
      Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
  Packages/IrisSearch/Sources/Digester/Chunking/MarkdownChunker.swift:146
      Immutable value 'alt' was never used; consider replacing with '_' or removing it
  Minna/Views/Search/AskMinnaView.swift:185
      Accessibility Trait for Button Violation: All views with tap gestures added should include the .isButton or the .isLink accessibility traits (accessibility_trait_for_button)
  Minna/Views/Common/NotificationsView.swift:128
      Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
  Minna/Local Search/IrisDBController.swift:55
      Todo Violation: TODOs should be resolved (Watch for downloads so we can ...) (todo)
  Minna/Utility/Alerts/AlertCenter.swift:33
      Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
  file:///Volumes/workspace/DerivedData/SourcePackages/checkouts/mlx-swift/Source/Cmlx/mlx-generated/metal/steel/attn/kernels/steel_attention.h:426
      Constexpr if is a C++17 extension
  Minna/Utility/FuzzyMatch.swift:53
      Is Disjoint Violation: Prefer using `Set.isDisjoint(with:)` over `Set.intersection(_:).isEmpty` (is_disjoint)
  Minna/Views/Settings/Screens/AssetProvider.swift:58
      Implicit Optional Initialization Violation: Optional should be implicitly initialized without nil (implicit_optional_initialization)
  Minna/Views/Common/Components/NavigationTitle.swift:13
      Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
  Minna/Views/Add Folder/AddFolderForm.swift:103
      Accessibility Label for Image Violation: Images that provide context should have an accessibility label or should be explicitly hidden from accessibility (accessibility_label_for_image)
  Minna/Database/FrontendDatabase.swift:47
      Vertical Whitespace Violation: Limit vertical whitespace to a single empty line; currently 2 (vertical_whitespace)
  Minna/Views/Chat/ModelSelector.swift:104
      Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace (closure_parameter_position)
  Minna/Views/Common/File Cards/OpaqueFileCard.swift:120
      Todo Violation: TODOs should be resolved (Support multi-rename, look at ...) (todo)