Prevent FFmpeg errors when generating thumbnails for videos with multiple video streams.#28162
Open
pinhao wants to merge 2 commits intoimmich-app:mainfrom
Open
Prevent FFmpeg errors when generating thumbnails for videos with multiple video streams.#28162pinhao wants to merge 2 commits intoimmich-app:mainfrom
pinhao wants to merge 2 commits intoimmich-app:mainfrom
Conversation
Prevent ffmpeg errors when generating thumbnails. Without specifying the index of the video stream the options were applying to all video streams in the file. In the case of files generated by dji osmo action 6, that caused ffmpeg to throw an error because it has an hevc and mjpeg stream.
Didn't need to remap video
|
Label error. Requires exactly 1 of: changelog:.*. Found: 🗄️server. A maintainer will add the required label. |
Member
|
Thanks for the PR! You'll need to update the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #24828
Thumbnail generation already selects a specific video stream through
VideoStreamInfo.index, but the metadata bitstream filter was-bsf:v, which applies to every video stream in the input.This can fail for valid video containers that include additional video streams. In one reproducible case, a DJI Osmo Action 6 MP4 contains a primary HEVC stream and an attached MJPEG picture stream. FFmpeg fails because
hevc_metadatais applied to the MJPEG stream.This change the bitstream filter to the main video stream index.
How Has This Been Tested?
hevc_metadatato the MJPEG stream.hevc_metadataFFmpeg error.Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
No LLM was used