fix(mobile): prevent live photo from getting stuck during dismiss animation#28080
Open
fix(mobile): prevent live photo from getting stuck during dismiss animation#28080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where a Live Photo would get stuck in the close animation, if a user tried to dismiss the asset viewer, and the Live Photo stops playing in the animation.
This happens because _buildPhotoView rebuilds mid animation and switches from PhotoView.customChild to PhotoView.
FIX: we "freeze" the live photo. Which means if it's currently playing we don't switch away from the video viewer (photo viewer custom child) till the animation finishes.
Fixes #27710
How Has This Been Tested?
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
Claude did most of the implementation, with my guidance on what to implement. I gave it specific instructions on what to change. I reviewed the code and fixed issues I found.