Skip to content

fix(mobile): prevent live photo from getting stuck during dismiss animation#28080

Open
LeLunZ wants to merge 3 commits intomainfrom
bugfix/live-photo-stuck
Open

fix(mobile): prevent live photo from getting stuck during dismiss animation#28080
LeLunZ wants to merge 3 commits intomainfrom
bugfix/live-photo-stuck

Conversation

@LeLunZ
Copy link
Copy Markdown
Collaborator

@LeLunZ LeLunZ commented Apr 25, 2026

Description

This PR fixes an issue where a Live Photo would get stuck in the close animation, if a user tried to dismiss the asset viewer, and the Live Photo stops playing in the animation.

This happens because _buildPhotoView rebuilds mid animation and switches from PhotoView.customChild to PhotoView.

FIX: we "freeze" the live photo. Which means if it's currently playing we don't switch away from the video viewer (photo viewer custom child) till the animation finishes.

Fixes #27710

How Has This Been Tested?

  • iOS/android simulator

Checklist:

  • I have carefully read CONTRIBUTING.md
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

Claude did most of the implementation, with my guidance on what to implement. I gave it specific instructions on what to change. I reviewed the code and fixed issues I found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mobile: Remote Live Photo stuck in close animation

1 participant