fix: The memory generation job does not work correctly#28062
fix: The memory generation job does not work correctly#28062ExceptionsOccur wants to merge 1 commit intoimmich-app:mainfrom
Conversation
|
Label error. Requires exactly 1 of: changelog:.*. Found: 🗄️server. A maintainer will add the required label. |
|
The discussion you're referencing has long been resolved and a bug fix has been released. What are you actually fixing here? |
It seems this issue still hasn't been resolved. Last time, I only pointed out where the problem is, but I didn't submit the corresponding code, and it appears no one else has addressed it either. |
a2eff46 to
1ac43a8
Compare
|
I read through your comment in the discussion and I'm still failing to understand. AFAICT everything works as intended. With your changes you simply end up deleting all your memories nightly, which surely cannot be the goal? |
Description
1.The memory generation job fails to run correctly due to a database field issue. For details, see discussions#25906.
2.Modify the job's execution condition: if the execution time does not match the nightly tasks settings, it should be considered a manually triggered job.
3.Since the memory and memory_asset tables lack unique constraints, manually running the memory generation job multiple times results in duplicate records. Therefore, the cleanup logic needs to be adjusted. The solution is to clear all existing records and regenerate them.
How Has This Been Tested?
none
API Changes
none
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
none