feat: sort albums by total size#28057
feat: sort albums by total size#28057Shadi-Alrashoodi wants to merge 1 commit intoimmich-app:mainfrom
Conversation
|
Label error. Requires exactly 1 of: changelog:.*. Found: 📱mobile, 🖥️web, 🗄️server. A maintainer will add the required label. |
Adds a "Total size" sort option on the Albums page for web and mobile. Server exposes totalSize on AlbumResponseDto, summed from asset_exif.fileSizeInByte in the existing album metadata query.
5eda17f to
718ba1f
Compare
Even the branch name leads with |
|
No - Claude helped me understand the code and draft parts of it, but I directed the feature, reviewed every change, and tested it myself. |
|
Thank you for the PR. I am hesitant to accept this PR, as it could cause performance issues, since it will do a left join with the exif table for all assets in the get albums call. To better understand the impact, I'd like to get the request time difference between Can you help me get that? |
Description
Adds a "Total size" sort option on the Albums page for web and mobile. Server exposes totalSize on AlbumResponseDto, summed from asset_exif.fileSizeInByte in the existing album metadata query.
How Has This Been Tested?
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
Used Claude to navigate the codebase and identify patterns to follow.