Skip to content

fix(jin-frame): fix inheritance metadata bug in getFieldMetadata; add silent scripts#197

Merged
imjuni merged 4 commits into
masterfrom
develop
Apr 28, 2026
Merged

fix(jin-frame): fix inheritance metadata bug in getFieldMetadata; add silent scripts#197
imjuni merged 4 commits into
masterfrom
develop

Conversation

@imjuni

@imjuni imjuni commented Apr 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • Critical bug fix: getFieldMetadata에서 Reflect.getOwnMetadataReflect.getMetadata로 변경하여 상속 시 부모 클래스의 필드 메타데이터(@Body, @Query 등)가 자식 클래스에 올바르게 전달되도록 수정
    • 자식이 부모와 동일한 필드를 오버라이드하면 자식 데코레이터가 우선 적용됨을 테스트로 검증
  • Silent mode scripts: lint:silent, test:silent 추가 및 pre-commit hook에 test:silent 적용

Test plan

  • 484 tests passing
  • Inheritance metadata test: parent fields visible in child
  • Override test: child decorator takes precedence over parent for same field

🤖 Generated with Claude Code

imjuni and others added 4 commits April 29, 2026 02:05
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ritance support

Replace Reflect.getOwnMetadata with Reflect.getMetadata so that field
decorators defined on parent classes are correctly inherited by child classes.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@imjuni imjuni merged commit 85e8df5 into master Apr 28, 2026
3 checks passed
@codecov

codecov Bot commented Apr 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (2b72773) to head (8afa2b8).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #197   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          107       107           
  Lines         1088      1088           
  Branches       289       289           
=========================================
  Hits          1088      1088           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant