Skip to content

feat(jin-frame): validateStatus in FrameOption, safeParse fix, PUT/PATCH multipart, comment translations#196

Merged
imjuni merged 2 commits into
masterfrom
develop
Apr 28, 2026
Merged

feat(jin-frame): validateStatus in FrameOption, safeParse fix, PUT/PATCH multipart, comment translations#196
imjuni merged 2 commits into
masterfrom
develop

Conversation

@imjuni

@imjuni imjuni commented Apr 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • validateStatus in FrameOption: validateStatus can now be set at the decorator level (@Post, @Get, etc.) and will be applied to all _execute() calls. Resolution priority: _execute() option > FrameOption decorator > default (response.ok).
  • safeParse fix: safeParse now returns the raw string instead of undefined when JSON.parse fails, fixing plain-text (boolean, string, number) API responses.
  • PUT/PATCH multipart/form-data: Extended multipart/form-data support to include PUT and PATCH methods (was POST-only).
  • Korean comment translations: All remaining Korean source comments translated to English.
  • Naming convention docs: Added naming convention documentation pages (EN/KO) and registered in sidebar.
  • Axios removal from docs: Replaced all Axios references in docs with native fetch equivalents.
  • OAuth2 remnant removed: Removed refreshToken from AuthorizationData.
  • Version bumps: 5.0.0 → 5.0.1 → 5.0.2 → 5.0.3

Test plan

  • All 482 tests passing
  • New tests for validateStatus in FrameOption (2 cases)
  • New tests for safeParse (8 cases)
  • New tests for PUT/PATCH multipart/form-data (2 cases)

🤖 Generated with Claude Code

imjuni and others added 2 commits April 29, 2026 01:44
…nslate comments to English

- Add validateStatus to FrameOption so it can be set at the decorator level
- Register validateStatus in getFrameOption so it is stored in _option
- Update JinFrame to resolve validateStatus with priority:
  _execute option > FrameOption decorator > default (response.ok)
- Add tests: 404-as-success via FrameOption, _execute override takes precedence
- Translate all remaining Korean comments to English:
  FieldsOf, BuilderFor, getUrl, pushRequestMeta, getRequestMeta,
  getBodyMap, BaseValidator, FrameRetry, Formatter, FrameOption

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov

codecov Bot commented Apr 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (729261d) to head (35f4e80).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #196   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          107       107           
  Lines         1088      1088           
  Branches       289       289           
=========================================
  Hits          1088      1088           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imjuni imjuni merged commit 2b72773 into master Apr 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant