Conversation
Previously safeParse returned undefined on parse failure, causing APIs that respond with a plain string (e.g. "hello") to produce undefined data. Now falls back to the raw string so plain-text responses are preserved. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- fix safeParse to return raw string instead of undefined for plain-text responses Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #195 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 107 107
Lines 1088 1088
Branches 289 289
=========================================
Hits 1088 1088 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
safeParse버그 수정: API가 plain string(hello등 JSON-encode되지 않은 문자열)을 반환할 때JSON.parse가 실패하여undefined가 데이터로 설정되던 문제 수정undefined반환JSON.parse가 정상 처리하므로 영향 없음)safeParse.test.ts신규 추가: JSON object, array, boolean, number, null, plain string 8가지 케이스 커버Test plan
pnpm --filter jin-frame test)safeParse단위 테스트 8개 모두 통과🤖 Generated with Claude Code