Skip to content

fix(jin-frame): v5.0.2 — safeParse plain-text response bug fix#195

Merged
imjuni merged 2 commits into
masterfrom
develop
Apr 28, 2026
Merged

fix(jin-frame): v5.0.2 — safeParse plain-text response bug fix#195
imjuni merged 2 commits into
masterfrom
develop

Conversation

@imjuni

@imjuni imjuni commented Apr 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • safeParse 버그 수정: API가 plain string(hello 등 JSON-encode되지 않은 문자열)을 반환할 때 JSON.parse가 실패하여 undefined가 데이터로 설정되던 문제 수정
    • 수정 전: parse 실패 시 undefined 반환
    • 수정 후: parse 실패 시 원본 문자열 반환 (boolean/number는 JSON.parse가 정상 처리하므로 영향 없음)
  • safeParse.test.ts 신규 추가: JSON object, array, boolean, number, null, plain string 8가지 케이스 커버

Test plan

  • 전체 테스트 480개 통과 (pnpm --filter jin-frame test)
  • safeParse 단위 테스트 8개 모두 통과

🤖 Generated with Claude Code

imjuni and others added 2 commits April 28, 2026 17:14
Previously safeParse returned undefined on parse failure, causing APIs
that respond with a plain string (e.g. "hello") to produce undefined data.
Now falls back to the raw string so plain-text responses are preserved.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- fix safeParse to return raw string instead of undefined for plain-text responses

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov

codecov Bot commented Apr 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ed33067) to head (3d0c93d).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #195   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          107       107           
  Lines         1088      1088           
  Branches       289       289           
=========================================
  Hits          1088      1088           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imjuni imjuni merged commit 729261d into master Apr 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant