fix(deps): require @imagekit/javascript ^5.5.0 and set up Release Please - #148
Merged
Merged
Conversation
Adds release-please-config.json, .release-please-manifest.json (seeded at 4.0.1), the Release Please workflow, and the Release-As sync workflow used by the other ImageKit SDK repos. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…tion support Raises the minimum @imagekit/javascript to 5.5.0, which adds the `density` transformation (serialized as `dn`). Consumers with an older lockfile pin would otherwise keep 5.4.x and silently drop the parameter. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@nuxt/content v3 requires a SQLite driver (better-sqlite3) at `nuxt prepare`, which fails the postinstall step in CI. The test app never uses the module, so remove it instead of adding the driver. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Playwright's webServer wrapper only prints the last line of a failed build, hiding the actual error. Run the build as its own step first. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Vite's tsconfig loader walks up to the repo root tsconfig.node.json, which extends @tsconfig/node22. In CI the root node_modules is never installed for the test job, so the build failed with TSCONFIG_ERROR. Declare the package in the nuxt test app, as the vue-ts test app already does. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This reverts commit ae2a811.
Vite's tsconfig loader (tsconfck) walks up from the test app to the repo root tsconfig.node.json, which extends @tsconfig/node22 resolved from the root node_modules. The test job never installed the root, so the nuxt build failed with TSCONFIG_ERROR in CI while passing locally. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Release Please inserts new entries before the first version heading that is preceded by a newline. With the file starting directly at '## x.y.z', the first match was the second heading and new releases would land out of order. A top-level heading fixes the insertion point. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Same shape as imagekit-javascript's publish workflow: - id-token: write, no NODE_AUTH_TOKEN, no `npm whoami` - Node 24 with npm pinned to the 11 line (>= 11.5.1 needed; npm@latest is 12 and refuses older Node) - `npm publish --provenance` - workflow_dispatch so a failed publish can be re-run from the default branch without re-tagging The trusted publisher on npmjs.com must reference this file's name, `publish.yml`. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two things, in two commits:
1.
fix(deps): require@imagekit/javascript^5.5.0@imagekit/javascript5.5.0 adds thedensitytransformation (dn). Because @imagekit/vue only declared^5.1.0, a consumer whose lockfile pins an older 5.x would keep it after upgrading this package and the URL builder would silently dropdensity. Raising the floor forces the resolver to pick up 5.5.0 on the next upgrade. Fresh installs already resolve to 5.5.0 either way.package-lock.jsonroot version was stale at 4.0.0 and is now synced to 4.0.1.2.
ci: set up Release PleaseSame layout as imagekit-javascript:
release-please-config.jsonand.release-please-manifest.jsonseeded at the current version 4.0.1.github/workflows/release-please.yml, runs on push tomasterwith the org-levelRELEASE_PLEASE_TOKEN(already shared with this repo).github/workflows/sync-release-as.yml, lets you retitle the release PR to pin a versionChoices worth a look:
include-v-in-tag: false, so tags stay4.0.1-style like the existing releases. Release Please finds the last release by that tag on its first run, so no bootstrap SHA is needed.release: published, so a Release Please release will publish to npm with no change.Merge guidance
Squash-merge with the PR title as the commit message, or merge-commit as is. Either way the
fix(deps)commit is a releasable change, so Release Please will open a release: 4.0.2 PR right after this lands. Merge that to publish.🤖 Generated with Claude Code