fix: Guard signingConfigs behind key.properties existence check#2102
Open
sunbird89629 wants to merge 1 commit into
Open
fix: Guard signingConfigs behind key.properties existence check#2102sunbird89629 wants to merge 1 commit into
sunbird89629 wants to merge 1 commit into
Conversation
Wrap signingConfigs and its usage in `keystorePropertiesFile.exists()` to prevent `null cannot be cast to non-null type kotlin.String` error when key.properties is missing (e.g., fresh clone or local dev).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signingConfigsand its usage inkeystorePropertiesFile.exists()checknull cannot be cast to non-null type kotlin.Stringerror whenkey.propertiesis missingProblem
The example app's
build.gradle.ktsunconditionally accesseskeystoreProperties["keyAlias"] as Stringin thesigningConfigsblock. Whenkey.propertiesdoesn't exist (fresh clone, local dev), this crashes with:Fix
Guard both the
signingConfigscreation and its usage inbuildTypes.releasebehindkeystorePropertiesFile.exists().Test plan
flutter build apkworks withoutkey.propertiesflutter build apk --releaseworks with validkey.properties