This repository was archived by the owner on Jun 15, 2018. It is now read-only.
Added domain functionality#22
Closed
BlackLotus wants to merge 2 commits into
Closed
Conversation
Author
|
It's probably best to have only one pull request for the same functionality open... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some wikis need a domain to login or have multiple domains that can be used.
Here is minimal domain support (and one additional line that tells you the return output why the login didn't work).
There is already a pull request for domain functionality #21 that looks like my first attempt.
Don't know which is more suited (if any), but wanted to offer a different approach (even thought I think the first implementation was good)