(MOT-4187) fix(iii-directory): make explicit repo downloads visible - #588
(MOT-4187) fix(iii-directory): make explicit repo downloads visible#588rohitg00 wants to merge 1 commit into
Conversation
directory::skills::download with a repo source (the README quickstart's own example) wrote files that filter_unregistered then hid: the namespace matches no installed worker, and the repo path wrote no completion marker, so nothing distinguished an intentional pull from an uninstalled worker's leftovers. Function-path downloads now write the completion marker for both sources (repo markers record source "repo" and the branch; registry markers keep their existing shape), and the visibility filter keeps namespaces whose marker records an explicit repo download. Registry function-path downloads gain provenance markers too, matching the auto-download path.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 33 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
skill-check — worker0 verified, 48 skipped (no docs/).
Four for four. Nicely done. |
1 participant
Problem
directory::skills::downloadwith a repo source, the exact call this worker's README quickstart demonstrates, produces invisible knowledge under default config: the downloaded namespace matches no installed worker, sofilter_unregistered: truehides it fromlist/get/index. The repo path also wrote no completion marker, so nothing on disk distinguished an intentional pull from an uninstalled worker's leftovers, and the reconcile had no provenance for it either. Reproduced live: a repo download returnedskills_writtenand thengeton the namespace failed andlistomitted it.Change
Two mechanisms, both marker-based:
source: "repo"and the branch; registry markers keep their existing shape. Registry function-path downloads previously wrote no marker at all (only auto-download did), so they gain provenance too.repo_pinned_namespaces, read from disk per resolve). Leftover namespaces from removed workers keep their current hidden behavior: their markers sayregistry, and worker presence still governs those.Tests
New unit tests: pinned namespace survives the filter while an unmarked orphan stays hidden; marker roundtrip unchanged for registry shape.
cargo fmt --check,clippy --all-targets --all-features -- -D warnings,cargo test --lib(262) pass.Overlaps
download.rswith #573; whichever lands second rebases trivially (adjacent marker-code hunks).Refs MOT-4187