Skip to content

(MOT-4163) providers: unify identity prompts on the minimal core - #560

Open
rohitg00 wants to merge 1 commit into
mainfrom
provider-identity-minimal
Open

(MOT-4163) providers: unify identity prompts on the minimal core#560
rohitg00 wants to merge 1 commit into
mainfrom
provider-identity-minimal

Conversation

@rohitg00

@rohitg00 rohitg00 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

What

The seven provider identity prompts (28 to 32 KB each, ~7,100 to 7,600 tokens live) unify on the minimal core from #558 (~1,800 tokens each), plus the per-provider lines their tests pin:

  • provider-anthropic, provider-llamacpp, provider-zai: the IMPORTANT: NEVER invent function ids emphasis line
  • provider-kimi: the sentence-case Never invent function ids variant
  • provider-openai, provider-openai-codex, provider-xai: the ## Autonomy and persistence section, kept verbatim

All seven declaration test suites pass unchanged: they pin starts_with, agent_trigger, and the per-provider lines above, and each still ships its embedded prompt via include_str!.

Why

The seven identities are near-copies of the harness prompt that have already drifted into three divergent variants. Every session on any of these providers pays ~7,100+ system tokens per generation; 63% of that is the orchestration playbook, which #558 moves into on-demand skills. After this PR each provider serves the same 1,800-token core, deep playbooks are pulled from harness/* skills only when a task needs them, and per-provider tuning is a visible delta instead of a fork of the whole prompt.

Live A/B evidence is in #558: minus 70% system tokens per generation with correctness parity across 13 sessions, measured with the anthropic identity as baseline.

Dependencies

Depends on #558 shipping the harness/* playbook skills the core points to. The router operator override (providers.<name>.system_prompt in llm-router config) remains the per-rig escape hatch in both directions.

Draft: needs #558 direction agreement first.

Linear

Closes MOT-4163. Part of MOT-4157.

Open question from review

The seven files are three content variants generated from one core plus per-provider inserts; the generator ran offline. If this lands, a committed generator plus a CI drift check (regenerate and diff) would keep the eight copies honest - it can be added here or as a follow-up; the open question is where codegen belongs in this repo.

@vercel

vercel Bot commented Jul 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
workers Ready Ready Preview, Comment Jul 22, 2026 1:29pm
workers-tech-spec Ready Ready Preview, Comment Jul 22, 2026 1:29pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

skill-check — worker

0 verified, 47 skipped (no docs/).

Layer Result
structure
vale
ai
render

Four for four. Nicely done.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@rohitg00, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cfff9ba7-899c-4ed5-a430-1b000ac6f281

📥 Commits

Reviewing files that changed from the base of the PR and between 28f44dc and 9a710c8.

📒 Files selected for processing (7)
  • provider-anthropic/prompts/identity.txt
  • provider-kimi/prompts/identity.txt
  • provider-llamacpp/prompts/identity.txt
  • provider-openai-codex/prompts/identity.txt
  • provider-openai/prompts/identity.txt
  • provider-xai/prompts/identity.txt
  • provider-zai/prompts/identity.txt
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch provider-identity-minimal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rohitg00 rohitg00 changed the title providers: unify identity prompts on the minimal core (MOT-4163) providers: unify identity prompts on the minimal core Jul 22, 2026
@rohitg00
rohitg00 marked this pull request as ready for review July 22, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant