Support pdbx_poly_seq_scheme heterogeneous composition - #198
Open
benmwebb wants to merge 2 commits into
Open
Conversation
The _pdbx_poly_seq_scheme table now requires a new ihm_model_id_list data item that lists all models that have coordinates for a particular residue. This is to enable PDB tools to fully support heterogeneous composition. Use our existing not-modeled-residue ranges to populate this data item on output.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
=======================================
Coverage 98.86% 98.86%
=======================================
Files 33 33
Lines 10890 10924 +34
Branches 2605 2617 +12
=======================================
+ Hits 10766 10800 +34
Misses 68 68
Partials 56 56 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Ranges are sorted, so if this range does not overlap, no further ranges will either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _pdbx_poly_seq_scheme table now requires a new ihm_model_id_list data item that lists all models that have coordinates for a particular residue. This is to enable PDB tools to fully support heterogeneous composition. Use our existing not-modeled-residue ranges to populate this data item on output.
This should only be merged when the corresponding dictionary branch https://github.com/ihmwg/IHMCIF/tree/poly-seq-scheme is merged.