chore: bump ignition-devs/copier-templates to 0.4.27#324
Merged
Conversation
Contributor
Reviewer's GuideUpdates GitHub Actions workflows to use pinned SHAs for v7.0.0 of shared coatl-dev workflows/actions and newer v6.x versions of official actions, adjusts publish workflow job conditions, reorders (but functionally preserves) Commitizen pre-commit hooks, and bumps the Copier template reference from 0.4.25 to 0.4.27. Flow diagram for updated publish workflow job conditions in GitHub Actionsflowchart LR
github_event[GitHub event]
subgraph publish_workflow[.github/workflows/publish.yml]
direction LR
tox_package[Tox package tests]
tox_stubs[Tox stubs tests]
pypi_publish_package[PyPI upload package]
pypi_publish_stubs[PyPI upload stubs]
end
github_event --> tox_package
github_event --> tox_stubs
tox_package --> pypi_publish_package
tox_stubs --> pypi_publish_stubs
%% New behavior: tox jobs only run for pull_request events
tox_package:::prOnly
tox_stubs:::prOnly
classDef prOnly fill:#eef,stroke:#88f,stroke-width:1px;
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
.github/workflows/publish.yml, addingif: ${{ github.event_name == 'pull_request' }}to thetox-packageandtox-stubsjobs effectively disables these checks for tag/release events; confirm this aligns with your intended publish flow since it may prevent running tox before publishing to PyPI.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `.github/workflows/publish.yml`, adding `if: ${{ github.event_name == 'pull_request' }}` to the `tox-package` and `tox-stubs` jobs effectively disables these checks for tag/release events; confirm this aligns with your intended publish flow since it may prevent running tox before publishing to PyPI.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update CI and publish workflows to use pinned v7 coatl-dev reusable workflows and actions, and refresh Copier template metadata.
Build:
CI:
Chores: