Skip to content

refactor(exceptions): update JavaError's inner_exception type#320

Merged
cesarcoatl merged 1 commit into
mainfrom
refactor/exceptions/Optional-InnerException
May 29, 2026
Merged

refactor(exceptions): update JavaError's inner_exception type#320
cesarcoatl merged 1 commit into
mainfrom
refactor/exceptions/Optional-InnerException

Conversation

@cesarcoatl

@cesarcoatl cesarcoatl commented May 29, 2026

Copy link
Copy Markdown
Member

make it Optional

Summary by Sourcery

Enhancements:

  • Relax the type of JavaError.inner_exception and constructors (including GatewayError and MSSQLError) to Optional[InnerException] in both implementation and stubs for better typing accuracy.

@sourcery-ai

sourcery-ai Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors the JavaError and its subclasses so that inner_exception is consistently typed as Optional[InnerException] in both runtime code and type stubs, aligning the default None value with the type hints.

File-Level Changes

Change Details Files
Make JavaError.inner_exception and related constructor parameters Optional to match default None and improve type correctness.
  • Change JavaError.inner_exception class attribute type from InnerException to Optional[InnerException] in the implementation.
  • Update JavaError.init signature so inner_exception parameter is typed as Optional[InnerException] in the implementation.
  • Update GatewayError.init and MSSQLError.init signatures so inner_exception parameters are typed as Optional[InnerException] in the implementation.
  • Update the .pyi stubs for JavaError, GatewayError, and MSSQLError so inner_exception attributes and constructor parameters are typed as Optional[InnerException].
src/incendium/exceptions.py
stubs/stubs/incendium/exceptions.pyi

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@cesarcoatl cesarcoatl merged commit 8c496e3 into main May 29, 2026
6 checks passed
@cesarcoatl cesarcoatl deleted the refactor/exceptions/Optional-InnerException branch May 29, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant