Conversation
Hyvä themes don't use RequireJS, so x-magento-init scripts aren't processed. This adds direct script loading for Hyvä pages via store-hyva.phtml template. Also adds Docker config for Magento 2.4.8-p4 with PHP 8.4 and OpenSearch.
- Remove RequireJS dependency for universal theme compatibility (Luma, Hyvä, custom) - Use external loader.js instead of inline scripts for CSP compliance - Move block to before.body.end for better cross-theme support - Config passed via data attributes for security
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
… in loader.js Add security check to validate that binding URL is either relative or same-origin before loading script. Prevents potential XSS attacks by blocking external script sources.
cblanc
approved these changes
Jun 3, 2026
Member
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Member
|
🎉 This PR is included in version 2.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hyvä themes don't use RequireJS, so x-magento-init scripts aren't processed. This adds direct script loading for Hyvä pages via store-hyva.phtml template.
Also adds Docker config for Magento 2.4.8-p4 with PHP 8.4 and OpenSearch.