Added observers for SubmitText and ModifyText#44
Open
Sigma-dev wants to merge 1 commit into
Open
Conversation
PPakalns
suggested changes
Nov 12, 2025
| /// The text input entity that submitted the text | ||
| pub entity: Entity, | ||
| /// The submitted text | ||
| pub text: String, |
There was a problem hiding this comment.
I would suggest removal of text field.
If text is very long, raising EntityEvents on each change with text when text is modified is costly.
Instead users can retrieve text from the text edit entity manually when entity event is raised and text retrieval is needed.
There was a problem hiding this comment.
This avoids a lot of other changes that can be now reverted in this PR.
|
How is this PR? I also want to use observers. |
|
While we wait for the fate of this pull request, we can use this snippet to get us observers in the mean time: #[derive(EntityEvent)]
pub struct TextInputModified {
#[event_target]
pub text_input: Entity,
}
impl TextInputModified {
pub fn plugin(app: &mut App) {
app.add_systems(
Update,
|text_inputs: Query<Entity, Changed<TextInputContents>>, mut commands: Commands| {
for text_input in text_inputs {
commands.trigger(TextInputModified { text_input });
}
},
);
}
}(Don't forget to add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observers have made writing UI much better, so I thought I'd add the observers I've needed when using text inputs.
If you don't like the implementation tell me and I will change it.