Implement TextInputFilter so we can remove regex and once_cell dependencies.#24
Open
elijahimmer wants to merge 1 commit into
Open
Implement TextInputFilter so we can remove regex and once_cell dependencies.#24elijahimmer wants to merge 1 commit into
TextInputFilter so we can remove regex and once_cell dependencies.#24elijahimmer wants to merge 1 commit into
Conversation
elijahimmer
changed the title
TextInputFilter so we can remove regex and once_cell dependcies.
elijahimmer
changed the title
TextInputFilter so we can remove regex and once_cell dependcies.TextInputFilter so we can remove regex and once_cell dependencies.
|
Hello. I've just made PR #25 which conflicts with this one. Please review it before deciding whether to merge this one. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need regex to match a simple pattern, just implement it.
I removed the regex and once_cell dependencies by implementing the text filter.
This will technically break public API as
TextInputFilter::regexis removed, yet I don't think anyone would be using it.If that is a problem, we could add a feature to re-enable it, but I think that would be unnecessary.
I also added tests for the filters.
Just tell me if you want me to change anything and I can go ahead and do it.