Guard Dash._adjustIconSize against null firstIcon.icon (fixes #336 SIGABRT on GNOME 50) - #352
Open
svan71 wants to merge 1 commit into
Open
Guard Dash._adjustIconSize against null firstIcon.icon (fixes #336 SIGABRT on GNOME 50)#352svan71 wants to merge 1 commit into
svan71 wants to merge 1 commit into
Conversation
…ixes icedman#336 SIGABRT on GNOME 50)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #336.
On GNOME 50,
Dash._adjustIconSizecan run while an icon is mid-destruction; dereferencingfirstIcon.iconthen trips a fatal Clutter paint assertion and gnome-shell aborts (SIGABRT). Since the extension's relayout/animation work is what drives these extra_adjustIconSizecalls, the extension wraps it while enabled and bails out safely when the first icon has no.icon, restoring the original method on disable.Tested on GNOME 50 (Arch): the crash in #336 no longer reproduces with the guard in place; dash icon sizing still behaves normally in the overview.