Skip to content

Fix spurious icon bounce on app list changes - #347

Open
mihaly044 wants to merge 1 commit into
icedman:mainfrom
mihaly044:fix/spurious-icon-bounce
Open

Fix spurious icon bounce on app list changes#347
mihaly044 wants to merge 1 commit into
icedman:mainfrom
mihaly044:fix/spurious-icon-bounce

Conversation

@mihaly044

Copy link
Copy Markdown

Summary

  • Stop treating newly discovered dock actors as an instruction to bounce.
  • Preserve intentional launch feedback from the existing activation and custom-icon paths.

Problem

GNOME can rebuild dash item actors when an application starts or stops. The animator marked newly discovered non-favorite actors as found and then called _maybeBounce(icon, true). Passing true bypassed the normal window-count guard, so an actor recreated during an unrelated app-list update could bounce as though it had been launched or received attention.

This made apparently random dock icons jump when applications opened or closed, even though those applications had no notifications.

Fix

Actor discovery no longer triggers a bounce. Bounce requests tied to actual activation remain unchanged in Dock and DockItemMenu, so clicking a closed application or launching a custom item still retains the configured feedback.

Validation

  • node --check animator.js
  • git diff --check
  • Reproduced on Fedora 44 with GNOME Shell 50.3 and the open-app animation enabled. Runtime verification of the patched session requires reloading GNOME Shell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant