Fix spurious icon bounce on app list changes - #347
Open
mihaly044 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
GNOME can rebuild dash item actors when an application starts or stops. The animator marked newly discovered non-favorite actors as found and then called _maybeBounce(icon, true). Passing true bypassed the normal window-count guard, so an actor recreated during an unrelated app-list update could bounce as though it had been launched or received attention.
This made apparently random dock icons jump when applications opened or closed, even though those applications had no notifications.
Fix
Actor discovery no longer triggers a bounce. Bounce requests tied to actual activation remain unchanged in Dock and DockItemMenu, so clicking a closed application or launching a custom item still retains the configured feedback.
Validation