Fix: in the fullscreen video dash doc could be called - #344
Open
andrijzyn wants to merge 2 commits into
Open
Conversation
…t menu and Dash from full screen video
andrijzyn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for #211 , #142 .
Struts, the invisible rectangle covering the dock's area, was registered with trackFullscreen: false. Since addChrome defaults to affectsInputRegion: true, this invisible rectangle stays in the Shell's input region during fullscreen. On top of that, re-asserted struts.visible = !dock._hidden on every animation frame — and when autohide is off, _hidden is never true.
As result: an invisible click-swallowing barrier sits over the bottom of the fullscreen video, exactly where YouTube's play/pause controls and seek bar are.
Dwell, the 2-pixel reactive strip at the screen edge used to summon the dock also trackFullscreen: false, so even in fullscreen the bottommost pixels of the screen belong to the extension, not the browser. Hovering there fires the dock's enter/motion handlers, and clicks at the very edge never reach the video.
Screencast.From.2026-07-15.12-26-51.mp4