Repository navigation
[patch] Remove entitlement key and artifactory token as param of tekton pipeline - #2617
Open
Bhautik-Vala wants to merge 15 commits into
Open
Bhautik-Vala wants to merge 15 commits into
Bhautik-Vala wants to merge 15 commits into
Conversation
added 7 commits
September 23, 2026 18:44
…od will not break with empty secret name
added 7 commits
October 5, 2026 11:19
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This changes made for remove the ibm_entitlement_key, artifactory_username and artifactory_token from pipeline params list so it will not shown as plain text in the pipelins' parameter section and yaml file,
instead we will create secret with name similar to mas actions like:
for mas install we will create mas-install-secret , for mas update mas-update-secrets etc..
and then while passing ENV vars ( IBM_ENTITLEMENT_KEY, ARTIFACTORY_TOKEN, ARTIFACTORY_USERNAME ) to Task we will read it from secrets.
Related PR: ibm-mas/python-devops#515
JIRA: https://jsw.ibm.com/browse/MASCORE-15201
slack Discussion: https://ibm-mas.slack.com/archives/CNDB5GZ3P/p1783070622831499?thread_ts=1783001636.283929&cid=CNDB5GZ3P
Testing:
Tested with pfvt also with all applications except MVI - https://dashboard.ibmmas.com/tests/pfvtbhautik7/9603
Tested mas install, mas aiservice-install, mas update, mas backup, mas restore
if secret not created because we haven't passed the value of ibm entitlement key or artifactory token like in mas update then without that secret also update pipeline completed successfully.