Repository navigation
[patch] Update CLI issuerKind derivation for MAS 9.3+ - #2607
Merged
Merged
Conversation
IanBoden
requested changes
Sep 28, 2026
IanBoden
left a comment
Contributor
There was a problem hiding this comment.
This seems like something we should be able to add unit tests for
IanBoden
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In MAS 9.2, issuerKind controlled both internal and external certificate issuance, so the CLI had to prompt users for it and enforce that ClusterIssuer could only be used with --admin-mode cluster. In MAS 9.3+, the internal issuer is always Issuer (namespace-scoped, operator-managed), so issuerKind now only controls the external/public issuer — making it something the CLI can derive automatically from the user's DNS provider and routing choices rather than prompting for it explicitly.
This PR version-gates all issuerKind logic on 9.3.0. On 9.3+,
--mas-issuer-kindis no longer accepted as a CLI flag (a fatal error is raised if passed), and issuerKind is derived automatically: ClusterIssuer when a DNS provider (Cloudflare, CIS, Route53) is configured, Issuer when Let's Encrypt HTTP-01 is chosen in path mode or when no DNS provider is set. The old validation that blocked ClusterIssuer in namespaced/minimal modes is removed for 9.3+ since the internal issuer is no longer affected by this field. The DNS integration restriction in namespaced/minimal modes is also scoped to 9.2 only — on 9.3+ customers can use a ClusterIssuer for external certs regardless of admin mode. On 9.2, all existing validation and prompt behaviour is preserved unchanged.Related Issues
Testing
These changes are for MAS 9.3+ versions.

Install MAS without DNS integration (default domain) then it will use
Issuerautomatically:Install MAS with DNS integration (custom domain) then it will use

ClusterIssuerautomatically:Install MAS with Let's encrypt enabled for path routing mode then it will use

IssuerautomaticallyIf

by mistakesomeone passes the--mas-issue-kindflag to the CLI for a MAS 9.3 install: